-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add avahi as build dependency when platform mDNS is selected #18899
Merged
bzbarsky-apple
merged 2 commits into
project-chip:master
from
agners:remove-avahi-dependency-when-using-minimal
May 28, 2022
Merged
Only add avahi as build dependency when platform mDNS is selected #18899
bzbarsky-apple
merged 2 commits into
project-chip:master
from
agners:remove-avahi-dependency-when-using-minimal
May 28, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pullapprove
bot
requested review from
anush-apple,
arkq,
Byungjoo-Lee,
bzbarsky-apple,
carol-apple,
chrisdecenzo,
chshu,
chulspro,
Damian-Nordic,
dhrishi,
electrocucaracha,
emargolis,
erjiaqing,
franck-apple,
gjc13,
harimau-qirex,
hawk248,
harsha-rajendran,
isiu-apple,
jelderton,
jepenven-silabs,
jmartinez-silabs,
jtung-apple,
lazarkov,
LuDuda,
mrjerryjohns and
msandstedt
May 27, 2022 14:45
pullapprove
bot
requested review from
mspang,
rgoliver,
sagar-apple,
saurabhst,
selissia,
tcarmelveilleux,
tecimovic,
tehampson,
vijs,
vivien-apple,
wbschiller,
woody-apple,
xylophone21,
yufengwangca and
yunhanw-google
May 27, 2022 14:45
PR #18899: Size comparison from 4282726 to b8adddd Decreases (2 builds for linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
andy31415
approved these changes
May 27, 2022
mspang
approved these changes
May 27, 2022
mspang
reviewed
May 27, 2022
PR #18899: Size comparison from 4282726 to d53443c Increases above 0.2%:
Increases (18 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, nrfconnect, p6, telink)
Decreases (14 builds for cc13x2_26x2, linux)
Full report (37 builds for cc13x2_26x2, cyw30739, efr32, esp32, k32w, linux, mbed, nrfconnect, p6, telink)
|
mspang
approved these changes
May 27, 2022
bzbarsky-apple
approved these changes
May 28, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
When using the built-in minimal mdns implementation, CHIP still requires the avahi client libraries to be built on Linux. If no client libraries are present, building (e.g. using
scripts/build_python.sh -m minimal
) fails with:Change overview
Compile Platform DnssdImpl on Linux/WebOS only when platform mdns implementation is selected. Also drop avahi dependency accordingly.
Testing
Build test using Debian Bullseye container.